This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, rfc, 6?] Enable identical frame sanity check


On Wed, Jul 02, 2003 at 02:27:39PM -0400, Andrew Cagney wrote:
> Hello,
> 
> This patch enables the `is the prev frame identical to this frame' check 
> in get_prev_frame().  I forgot to enable it when I switched the frame ID 
> code from using the frame's PC to using the frame's function.  Noticed 
> this when reviewing Daniel's Arm frame update.
> 
> It should probably go straight into the mainline (tested on i386 and d10v).

d10v, AVR, and soon ARM all include this check as a silent stop
condition rather than an error... perhaps that has some significance.
I know it's hit at least on ARM.  I'd have to dumb down the prologue
analyzer if I wanted it not to be, or else figure out where an
inside_entry_func check has gone completely missing in the new frame
code.  Just putting it unwind_this_id didn't work (don't remember why
not).


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]