This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Re: Analyzing AMD64 corefiles on i386


   From: Andreas Schwab <schwab@suse.de>
   Date: Wed, 09 Jul 2003 13:56:44 +0200

   Michal Ludvig <mludvig@suse.cz> writes:

   |> 2003-07-09  Michal Ludvig  <mludvig@suse.cz>
   |> 
   |> 	* x86-64-linux-nat.c (regmap, supply_gregset, fill_gregset):
   |> 	Moved to x86-64-linux-tdep.c.
   |> 	* x86-64-linux-tdep.c (regmap, supply_gregset, fill_gregset):
   |> 	Moved from x86-64-linux-nat.c.

   Hmm, m68klinux-nat.c has this comment:

   /* Note both m68k-tdep.c and m68klinux-nat.c contain definitions
      for supply_gregset and supply_fpregset. The definitions
      in m68k-tdep.c are valid if USE_PROC_FS is defined. Otherwise,
      the definitions in m68klinux-nat.c will be used. This is a 
      bit of a hack. The supply_* routines do not belong in 
		     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      *_tdep.c files. But, there are several lynx ports that currently 
      ^^^^^^^^^^^^^^
      depend on these definitions. */

   What's the current wisdom about that?

It's still true.  If register conversion functions are implemented in
*-tdep.c files, they should not be named supply_gregset/fill_gregset.

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]