This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [commit] Simplify gdbarch.sh a tiny bit
On Thu, 10 Jul 2003, Andrew Cagney wrote:
Hello,
The attached simplfies gdbarch.sh a tiny bit - it uses gdb_assert
instead of internal_error in a few places (from memory gdbarch.sh was
written before gdb_assert was added).
I'm getting a build failure now:
Oh, flip. The bit to revert should be obvious. I'm off line for a few hours.
I've checked in the attached. I'm guessing its correct, my default
compiler doesn't get these warnings.
Andrew
gcc -c -g -O2 -I. -I../../gdb -I../../gdb/config
-DLOCALEDIR="\"/home/roth/local/avr/share/locale\"" -DHAVE_CONFIG_H
-I../../gdb/../include/opcode -I../../gdb/../readline/.. -I../bfd
-I../../gdb/../bfd -I../../gdb/../include -I../intl
-I../../gdb/../intl -DMI_OUT=1 -Wimplicit -Wreturn-type -Wcomment
-Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized
-Werror ../../gdb/gdbarch.c
cc1: warnings being treated as errors
../../gdb/gdbarch.c: In function
`gdbarch_deprecated_max_register_raw_size_p':
../../gdb/gdbarch.c:3425: warning: comparison between pointer and integer
../../gdb/gdbarch.c: In function
`gdbarch_deprecated_max_register_virtual_size_p':
../../gdb/gdbarch.c:3448: warning: comparison between pointer and integer
../../gdb/gdbarch.c: In function
`gdbarch_deprecated_call_dummy_stack_adjust_p':
../../gdb/gdbarch.c:3805: warning: comparison between pointer and integer
make: *** [gdbarch.o] Error 1
Is this related to your change?
2003-07-10 Andrew Cagney <cagney@redhat.com>
* gdbarch.sh: When a variable, but not a function, compare against
0. Fix problem in previous patch.
* gdbarch.c: Re-generate.
Index: gdbarch.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbarch.c,v
retrieving revision 1.234
diff -u -r1.234 gdbarch.c
--- gdbarch.c 10 Jul 2003 22:01:14 -0000 1.234
+++ gdbarch.c 11 Jul 2003 01:33:58 -0000
@@ -3422,7 +3422,7 @@
gdbarch_deprecated_max_register_raw_size_p (struct gdbarch *gdbarch)
{
gdb_assert (gdbarch != NULL);
- return gdbarch->deprecated_max_register_raw_size != NULL;
+ return gdbarch->deprecated_max_register_raw_size != 0;
}
int
@@ -3445,7 +3445,7 @@
gdbarch_deprecated_max_register_virtual_size_p (struct gdbarch *gdbarch)
{
gdb_assert (gdbarch != NULL);
- return gdbarch->deprecated_max_register_virtual_size != NULL;
+ return gdbarch->deprecated_max_register_virtual_size != 0;
}
int
@@ -3802,7 +3802,7 @@
gdbarch_deprecated_call_dummy_stack_adjust_p (struct gdbarch *gdbarch)
{
gdb_assert (gdbarch != NULL);
- return gdbarch->deprecated_call_dummy_stack_adjust != NULL;
+ return gdbarch->deprecated_call_dummy_stack_adjust != 0;
}
int
Index: gdbarch.sh
===================================================================
RCS file: /cvs/src/src/gdb/gdbarch.sh,v
retrieving revision 1.256
diff -u -r1.256 gdbarch.sh
--- gdbarch.sh 10 Jul 2003 22:01:14 -0000 1.256
+++ gdbarch.sh 11 Jul 2003 01:33:58 -0000
@@ -1732,7 +1732,11 @@
if [ -n "${predicate}" ]
then
printf " return ${predicate};\n"
- else
+ elif class_is_variable_p
+ then
+ printf " return gdbarch->${function} != 0;\n"
+ elif class_is_function_p
+ then
printf " return gdbarch->${function} != NULL;\n"
fi
printf "}\n"