This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fix info address for thread local vars


On Tue, Jul 22, 2003 at 02:40:13PM -0400, Elena Zannoni wrote:
> Michael Elizabeth Chastain writes:
>  > Hi Elena,
>  > 
>  > > I am also really tempted to commit the tls tests (to the mailine
>  > > only), otherwise, the tls feature will bitrot. I'll work through
>  > > refining the tests once they are in.
>  > 
>  > Could you file a PR like "tls tests not ready for prime time yet"
>  > and then shovel in a bunch of setup_kfail?
>  > 
>  > It's cheesy but it might be better than letting the tests bit rot.
>  > What do people think?
>  > 
>  > I'll even volunteer to sprinkle in the setup_kfail's if people
>  > think this is a useful idea.
>  > 
>  > Michael C
> 
> 
> OK, after the commits I get these errors on a RHL system with all the
> bits installed:
> 
> Running /home/ezannoni/gdb-sources/src/gdb/testsuite/gdb.threads/tls.exp ...
> FAIL: gdb.threads/tls.exp: info address me
> 
> 		=== gdb Summary ===
> 
> # of expected passes		59
> # of unexpected failures	1
> 
> 
> Running /home/ezannoni/gdb-sources/src/gdb/testsuite/gdb.threads/tls-shared.exp ...
> 
> 		=== gdb Summary ===
> 
> # of expected passes		9
> 
> 
> That failure is due to some other lossage with info address.
> I think we need a test for info address in the testsuite....
> 
> 
> info address me
> Symbol "me" is a variable with complex or multiple locations (DWARF2).
> (gdb) FAIL: gdb.threads/tls.exp: info address me
> 
> 
> OK, should I xfail/kfail it? I'll create a PR for this.

Sounds like a good idea.  Kfail, I think.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]