This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] revised m32r target
> Kei,
>>
>> I've checked in the .c files, as posted. Not bad, not bad at all.
>> Can you just see how many of the attached can also be fixed? I'll then
>> look at enabling it and pulling it into the 6 branch.
>>
>> Andrew
>
>
> Thank you for checking in. I revised m32r-tdep.c and m32r-rom.c.
> I think all warnings in your e-mail are fixed now. I attached the
> patch file.
>
> By the way, would you tell me how to get these warning messages?
I ran the script: "gdb_ari.sh -Wari <file>". See:
http://sources.redhat.com/gdb/current/ari/
http://sources.redhat.com/gdb/current/ari/gdb_ari.sh
> I built gdb with --enable-build-warnings, but gcc didn't show them.
Can you try configuring/building with:
--enable-gdb-build-warnings=,-Werror
(all targets should configure/build with that) I'm seeing the warnings:
m32r-tdep.c: In function `m32r_store_return_value':
m32r-tdep.c:289: warning: pointer of type `void *' used in arithmetic
m32r-rom.c: In function `m32r_upload_command':
m32r-rom.c:466: warning: `hostent' might be used uninitialized in this
function
Can you please try to reproduce / fix this.
BTW, for the ChangeLog I checked in:
2003-07-27 Andrew Cagney <cagney@redhat.com>
Patch from 2003-07-22 Kei Sakamoto <sakamoto.kei@renesas.com>:
* m32r-tdep.c (m32r_memory_insert_breakpoint): Fix code style -
operator at start and not end of line.
(decode_prologue): Ditto.
(m32r_frame_unwind_cache, m32r_unwind_sp, m32r_unwind_pc): Use
frame_unwind_register_unsigned instead of
frame_unwind_unsigned_register.
(m32r_read_pc): Use regcache_cooked_read_unsigned instead of
read_register.
(m32r_push_dummy_call): Use register_size instead of
REGISTER_RAW_SIZE.
(m32r_frame_sniffer): Replace m32r_frame_p.
(m32r_gdbarch_init): Call frame_unwind_append_sniffer.
* m32r-rom.c (report_transfer_performance): Delete extern
declaration.
(m32r_load, m32r_upload_command): Use print_transfer_performance
instead of report_transfer_performance.
(_initialize_m32r_rom): Use add_setshow_cmd instead of add_set_cmd
/ add_show_from_set.
as it better states what was changed.
Andrew