This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
tls test maintainer, was Re: [rfa/testsuite] gdb.threads/tls.{exp,c}fixes
Elena Zannoni wrote:
Michael Elizabeth Chastain writes:
> This patch fixes all the ERRORs that I see with
> native i686-pc-linux-gnu, red hat 8.0, glibc 2.2.93-5-rh.
> All the results are now PASS, FAIL, KFAIL, and UNSUPPORTED.
>
> The tls.exp change is a one-liner to initialize a variable
> in all cases (not just the PASS case).
>
> The tls.c change is the calls to sem_wait. The current code
> calls sem_wait and then tests errno. My code calls sem_wait
> and tests errno only if sem_wait failed. This is important,
> because I have observed a lot of test suite hangs caused by
> return_value = 0, errno = EINTR (happens about 75% to 90% of
> the time in my test bed).
>
> Tested on native i686-pc-linux-gnu, red hat 8.0, glibc 2.2.93-5-rh,
> with a variety of gcc's and binutils.
>
thanks, seems to work for me too.
elena
BTW, although this test is in the gdb.threads directory, of which I'm
listed as the maintainer of record, I'd like to recognize Elena as the
de facto maintainer of this test. ;-)