Re: [patch/testcase] gdb.asm/m32r.inc: fix compile error

[Andrew Cagney <ac131313 at redhat dot com>]

> On Mon, Aug 04, 2003 at 03:26:03PM +0900, Kei Sakamoto wrote:
>
> > Thank you, everyone. Now m32r is back! :-)
> >
> > The attached fixes compile errors of asm-source.exp for m32r-elf.
> > There are several missing symbols.
> >
> > It also replaces ld24 instruction with seth/add3 instruction.
> > ld24 can handle only 24bit address, so ld24 fails to set sp when
> > _stack is located at a large address.
> >
> > Kei Sakamoto
> >
> > ===
> >
> > 2003-08-04    Kei Sakamoto  <sakamoto.kei@renesas.com>
> >
> > * gdb.asm/m32r.inc : Add several missing symbols. Replace ld24
> >                      with seth/add3.
>
>
> Two minor things:
>   - You accidentally sent a reversed diff.
>   - ChangeLog formatting.  It should be:
>
> 2003-08-04  Kei Sakamoto  <sakamoto.kei@renesas.com>
>
> 	* gdb.asm/m32r.inc: Add several missing symbols. Replace ld24
> 	with seth/add3.
>
> One less minor thing: no other port needs to declare symbols.  It looks
> like part of libc is being dragged in somehow on m32r; could you
> explain why the symbols are necessary?

This, I suspect is a hangover from an historic foobar that no ones gone 
back to fix.  The original assembler tests used AS and LD making for a 
very raw test framework.  It was an intentional decision, very like the 
simulator tests, rely on an absolute minimum to get things working.

Unfortunatly, sometime back a change switched LD to GCC but at the time 
no one realised (or those reviewing remembered gdb.asm's intent). 
Anyway, it needs to be switched back and that isn't going to be pleasant ...

Andrew