This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, rfc] fix breakpoint.c's -Wformat-nonliteral probs


Hello,

The attached should fix the -Wformat-nonliteral problems in breakpoint.c. Since all the warnings were linked to sprintf(), I simply went through and eliminated all sprintf calls.

Note that it adds a new utility function:

xstrprintf(const char *format, ...);

thoughts on the new function?
thoughts on the patch?

I still need to put it through a native config but otherwize should commit it in a few days.

I've checked this in.


Andrew


2003-08-05 Andrew Cagney <cagney@redhat.com>

	* defs.h (xstrprintf): Declare.
	* utils.c (xstrprintf): New function.
	* breakpoint.c (insert_breakpoints): Replace sprintf and
	non-literal format strings, with xstrprintf and cleanups.
	(delete_breakpoint,breakpoint_re_set): Ditto.
	(commands_command, insert_breakpoints): Ditto.
	(bpstat_stop_status, break_at_finish_at_depth_command_1): Ditto.
	(break_at_finish_command_1): Ditto.




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]