This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA/i386]: Enable default support for SSE registers
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Mark Kettenis <kettenis at chello dot nl>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Tue, 12 Aug 2003 09:39:37 -0700
- Subject: Re: [RFA/i386]: Enable default support for SSE registers
- References: <1030722184305.ZM4145@localhost.localdomain> <1030729154932.ZM7867@localhost.localdomain> <863cg6riq5.fsf@elgar.kettenis.dyndns.org>
On Aug 12, 5:36pm, Mark Kettenis wrote:
> There is one more concern that I do have: If we include
> the SSE registers, we somehow should also set their values to
> something sensible for targets that don't support them. We already do
> this for Linux, but it makes more sense to add some code to
> i387_supply_fsave().
I just took a quick look at this. It's not obvious to me what you have
in mind. Would you mind taking care of this?
Also... I just noticed the following bit of code in i387-tdep.c:
i387_supply_register (int regnum, char *fsave)
{
if (fsave == NULL)
{
supply_register (regnum, NULL);
return;
}
Calling supply_register() with NULL will end up calling memcpy() with
NULL as the second argument. If memcpy() is told to copy a non-zero
number of characters, it'll SEGV.
> Go ahead and check this in on mainline.
It's in.
> Do you want it on the 6.0 branch too?
It's not critical, but it'd be nice.
Kevin