This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: trivial PATCH to dwarf2read.c:dwarf_attr_name

On Wed, Aug 27, 2003 at 11:57:41AM -0400, Andrew Cagney wrote:
> >Can you please find out.  There must be a stronger rationale then "it's 
> >>been in my local tree for years".
> >
> >
> >Well, the patch is certainly right.  GCC generates
> >DW_AT_MIPS_linkage_name on all targets, and has for as far back as I
> >have GCC sources to check it.
> 
> Can you please add a comment explaining exactly when/where this occures 
> then?  Someone looking that that code is going to assume that 
> DW_AT_MIPS_linkage_name is outside the #ifdef MIPS because of a 
> host/target cross platform problem and _not_ because GCC uses it for all 
> architectures.

Actually, I have no idea where the #ifdef MIPS came from, but it should
be removed.  There's no reason to recognize extensions only on a
specific platform, and their other uses are not protected.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]