This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[ob] PPC s/push_arguments/push_dummy_call/
- From: Andrew Cagney <ac131313 at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Tue, 09 Sep 2003 14:41:06 -0400
- Subject: [ob] PPC s/push_arguments/push_dummy_call/
Hello,
This patch simply replaces the PPC's push_arguments function signatures
with the corresponding push_dummy_call function signature. It neither
touches any of the corresponding function bodies, nor uses any of those
new arguments, so hence doesn't have any effect. Since PPC doesn't
define stack_align even theoretical problems with that can't occure.
It makes the more interesting and not so obvious patches that need to
follow easier.
committed,
Andrew
2003-09-09 Andrew Cagney <cagney@redhat.com>
* ppc-tdep.h (ppc_sysv_abi_push_dummy_call): Replace
"ppc_sysv_abi_push_arguments".
* ppc-sysv-tdep.c (ppc_sysv_abi_push_dummy_call): Replace
"ppc_sysv_abi_push_arguments".
* rs6000-tdep.c (rs6000_gdbarch_init): Set "push_dummy_call"
instead of "push_arguments".
(rs6000_push_dummy_call): Replace "rs6000_push_arguments".
Index: ppc-sysv-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/ppc-sysv-tdep.c,v
retrieving revision 1.5
diff -u -r1.5 ppc-sysv-tdep.c
--- ppc-sysv-tdep.c 13 May 2003 19:27:28 -0000 1.5
+++ ppc-sysv-tdep.c 9 Sep 2003 18:26:15 -0000
@@ -47,8 +47,10 @@
starting from r4. */
CORE_ADDR
-ppc_sysv_abi_push_arguments (int nargs, struct value **args, CORE_ADDR sp,
- int struct_return, CORE_ADDR struct_addr)
+ppc_sysv_abi_push_dummy_call (struct gdbarch *gdbarch, CORE_ADDR func_addr,
+ struct regcache *regcache, CORE_ADDR bp_addr,
+ int nargs, struct value **args, CORE_ADDR sp,
+ int struct_return, CORE_ADDR struct_addr)
{
int argno;
/* Next available general register for non-float, non-vector arguments. */
Index: ppc-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/ppc-tdep.h,v
retrieving revision 1.16
diff -u -r1.16 ppc-tdep.h
--- ppc-tdep.h 12 Apr 2003 17:41:25 -0000 1.16
+++ ppc-tdep.h 9 Sep 2003 18:26:15 -0000
@@ -34,8 +34,13 @@
CORE_ADDR ppc_linux_frame_chain (struct frame_info *);
int ppc_sysv_abi_use_struct_convention (int, struct type *);
int ppc_sysv_abi_broken_use_struct_convention (int, struct type *);
-CORE_ADDR ppc_sysv_abi_push_arguments (int, struct value **, CORE_ADDR, int,
- CORE_ADDR);
+CORE_ADDR ppc_sysv_abi_push_dummy_call (struct gdbarch *gdbarch,
+ CORE_ADDR func_addr,
+ struct regcache *regcache,
+ CORE_ADDR bp_addr, int nargs,
+ struct value **args, CORE_ADDR sp,
+ int struct_return,
+ CORE_ADDR struct_addr);
int ppc_linux_memory_remove_breakpoint (CORE_ADDR addr, char *contents_cache);
struct link_map_offsets *ppc_linux_svr4_fetch_link_map_offsets (void);
void ppc_linux_supply_gregset (char *buf);
Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.150
diff -u -r1.150 rs6000-tdep.c
--- rs6000-tdep.c 9 Sep 2003 04:41:32 -0000 1.150
+++ rs6000-tdep.c 9 Sep 2003 18:26:20 -0000
@@ -1118,8 +1118,10 @@
starting from r4. */
static CORE_ADDR
-rs6000_push_arguments (int nargs, struct value **args, CORE_ADDR sp,
- int struct_return, CORE_ADDR struct_addr)
+rs6000_push_dummy_call (struct gdbarch *gdbarch, CORE_ADDR func_addr,
+ struct regcache *regcache, CORE_ADDR bp_addr,
+ int nargs, struct value **args, CORE_ADDR sp,
+ int struct_return, CORE_ADDR struct_addr)
{
int ii;
int len = 0;
@@ -2967,9 +2969,9 @@
64-bit code. At some point in the future, this matter needs to be
revisited. */
if (sysv_abi && wordsize == 4)
- set_gdbarch_deprecated_push_arguments (gdbarch, ppc_sysv_abi_push_arguments);
+ set_gdbarch_push_dummy_call (gdbarch, ppc_sysv_abi_push_dummy_call);
else
- set_gdbarch_deprecated_push_arguments (gdbarch, rs6000_push_arguments);
+ set_gdbarch_push_dummy_call (gdbarch, rs6000_push_dummy_call);
set_gdbarch_deprecated_store_struct_return (gdbarch, rs6000_store_struct_return);
set_gdbarch_extract_struct_value_address (gdbarch, rs6000_extract_struct_value_address);