This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Properly define SSE registers for cygwin targets


On Sat, Sep 13, 2003 at 01:02:59PM +0200, Mark Kettenis wrote:
>   Date: Fri, 12 Sep 2003 22:27:59 -0400
>   From: Christopher Faylor <cgf@redhat.com>
>
>   Checked in, trunk and branch.
>
>   cgf
>
>   2003-09-12  Christopher Faylor  <cgf@redhat.com>
>
>	   * win32-nat.c: Reorganize so that defines used by target headers are
>	   actually defined by the system headers.
>	   * config/i386/tm-cygwin.h: Check for CONTEXT_EXTENDED_REGISTERS rather
>	   than HAVE_CONTEXT_EXTENDED_REGISTERS, since the latter actually exists.
>
>Hmm, this looks like a lost opportunity to get rid of a definition in
>tm-cygwin.h.  HAVE_SSE_REGS has been eliminated from all source files
>except win32-nat.c.  So a s/HAVE_SSE_REGS/CONTEXT_EXTENDED_REGISTERS/g
>in that file would have been sufficient.  This also removes the need
>to re-order the includes; out coding standards say that "defs.h"
>should always come first.

Where do you think CONTEXT_EXTENDED_REGISTERS comes from?

Another question:  If HAVE_SSE_REGS was eliminated from all source files
why wasn't it eliminated from win32-nat.c?  Did I miss a memo?

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]