This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] parse and eval breakpoint conditions with correct language
Joel Brobecker <brobecker@gnat.com> writes:
> > BTW, this setting of the global current_language all also worries me :-)
> > Should parse_expression take an explict language?
>
> Me too, actually. I think passing the langauge to parse_expression et al
> is a good idea. It's more work, but seems more manageable than using a
> couple of global variables.
>
> Jim, what do you think?
Definitely. Mucking around with globals just to keep something from
throwing away information you've got right at hand is pretty
indicative.
What gives me pause, though, is that the breakpoint_re_set_one isn't
calling parse_exp_1 directly --- it's calling decode_line_1. Are you
going to propagate the language all the way through there? How do you
see approaching this?