This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
RFA: Don't include value of expression in pc-fp.exp test name
- From: Jim Blandy <jimb at redhat dot com>
- To: Michael Elizabeth Chastain <mec at shout dot net>
- Cc: ac131313 at redhat dot com, carlton at kealia dot com, fnasser at redhat dot com,gdb-patches at sources dot redhat dot com
- Date: 30 Sep 2003 01:40:03 -0500
- Subject: RFA: Don't include value of expression in pc-fp.exp test name
- References: <200309291917.h8TJHLhn010447@duracef.shout.net>
Michael Elizabeth Chastain <mec@shout.net> writes:
> dc> What would make more of a difference for me (and,
> dc> presumably, for other people) would be to make it as easy as possible
> dc> to compare sum files: regularize the thread output a bit more, get rid
> dc> of gratuitous numbers (especially the value of $fp in pc-fp.exp).
>
> I'm all for that.
>
> Michael C
Like so?
2003-09-30 Jim Blandy <jimb@redhat.com>
* gdb.base/pc-fp.exp (get_valueofx): Don't include the value of
the expression in the pass message. This just creates spurious
differences in summary files.
Index: gdb/testsuite/gdb.base/pc-fp.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/pc-fp.exp,v
retrieving revision 1.1
diff -c -r1.1 pc-fp.exp
*** gdb/testsuite/gdb.base/pc-fp.exp 25 Sep 2002 20:30:38 -0000 1.1
--- gdb/testsuite/gdb.base/pc-fp.exp 30 Sep 2003 06:39:50 -0000
***************
*** 62,68 ****
gdb_expect {
-re "\\$\[0-9\]* = (0x\[0-9a-zA-Z\]+).*$gdb_prompt $" {
set val $expect_out(1,string)
! pass "get value of ${exp} ($val)"
}
timeout {
set size ${default}
--- 62,68 ----
gdb_expect {
-re "\\$\[0-9\]* = (0x\[0-9a-zA-Z\]+).*$gdb_prompt $" {
set val $expect_out(1,string)
! pass "get value of ${exp}"
}
timeout {
set size ${default}