This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Don't include value of expression in pc-fp.exp test name


Andrew Cagney writes:

Michael, you and I had an e-mail exchange about this very issue. The end result, last time, was no change.


Right.  You think there's a convention about "(...)",
and I think there isn't.

The testsuite contains plenty of cases where the approach of putting suplemental information in paren has been used. "(timeout)" being the most obvious example. Whether the convention or pratice or what ever has been used consistently, or uniformly, is of course a separate problem.


> Neither of us has changed our minds.

It is very important when an issue such as this re-emerges that all parties openly and transparently recognize there are differing opinions - "I think ..., but note that previously this wasn't resolved" - always be willing to raise the red flag so to speak.

The other thing is to not assume that people have closed minds.

Fact: there are 1500+ test names with "(...)" in them.

Question: do you think these test names are written incorrectly?

I'll take that as retorical.


If so, do you have any suggestions for alternate ways to rewrite
test names such as:


  # parentheses used for precedence
  gdb.base/arithmet.exp: print x-(y+w)
  gdb.base/arithmet.exp: print x/(y*w)
  gdb.base/arithmet.exp: print x-(y/w)
  gdb.base/arithmet.exp: print (x+y)*w

Now we're getting somewhere. You've suggested /\/\/.*$/ as an alternative pattern. Are there guidelines in the dejagnu doco?


Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]