This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] TARGET_ADJUST_BREAKPOINT_ADDRESS - patch 4 of 4


Kevin Buettner wrote:
On Oct 7, 4:00pm, Michael Snyder wrote:

Maybe "bpaddr - 4" could also be "bpaddr - sizeof (something)".


I hear alarm bells go off in my head whenever I see sizeof() used in
target specific code. (Sometimes it's perfectly okay, but I hear them
just the same.) So, what I've done instead is to define
``frv_instr_size'' and use that constant instead of 4 in
frv_gdbarch_adjust_breakpoint_address().

That's kinda what I meant. "sizeof" was a concept, not an operator. ;-)


Thanks for the tweaks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]