Re: [PATCH] frv-tdep.c: Stop backtraces in entry func, not entryfile

[Michael Snyder <msnyder at redhat dot com>]

Andrew Cagney wrote:
> > An FR-V user reported being unable to see useful backtraces when
> > debugging functions inside the entry file.  This patch fixes that
> > problem.  I think there's a problem with inside_entry_func() itself,
> > but that's a separate issue.  (If you are in the entry file,
> > backtraces don't stop at the entry func - they attempt to continue
> > beyond, but they do stop shortly thereafter.)
>
>
> What happens if that test is removed?
>
> I believe the below test has its origins in a d10v hack to get around 
> what was then a broken back-trace-past-main problem.  The problems been 
> fixed, but unfortunatly, the original hack keeps turning up.

Checking for the entry file/function?  Oh, it's older than that...


> > Kevin
> >
> >     * frv-tdep.c (frv_frame_this_id): Call inside_entry_func()
> >     instead of deprecated_inside_entry_file().
> >
> > Index: frv-tdep.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/frv-tdep.c,v
> > retrieving revision 1.54
> > diff -u -p -r1.54 frv-tdep.c
> > --- frv-tdep.c    14 Oct 2003 00:30:27 -0000    1.54
> > +++ frv-tdep.c    14 Oct 2003 20:40:18 -0000
> > @@ -1009,7 +1009,7 @@ frv_frame_this_id (struct frame_info *ne
> >  
> >    /* This is meant to halt the backtrace at "_start".  Make sure we
> >       don't halt it at a generic dummy frame. */
> > -  if (deprecated_inside_entry_file (func))
> > +  if (inside_entry_func (func))
> >      return;
> >  
> >    /* Check if the stack is empty.  */