Re: [commit] Don't call deprecated_inside_entry_file from ...id_unwind()

[Daniel Jacobowitz <drow at mvista dot com>]

On Fri, Oct 31, 2003 at 09:02:04PM -0500, Andrew Cagney wrote:
> 
> >Are you certain that none of those other architectures needed the hack
> >anyway?
> 
> To sound like a scratched record, until there is hard evidence that this 
> test is needed it should _not_ be enabled.  So far the only evidence is 
> that it is anything but needed:
> 
>   /* NOTE: vinschen/2003-04-01: Disabled.  It turns out that the call
>      to deprecated_inside_entry_file destroys a meaningful backtrace
>      under some conditions.  E. g. the backtrace tests in the
>      asm-source testcase are broken for some targets.  In this test
>      the functions are all implemented as part of one file and the
>      testcase is not necessarily linked with a start file (depending
>      on the target).  What happens is, that the first frame is printed
>      normaly and following frames are treated as being inside the
>      enttry file then.  This way, only the #0 frame is printed in the
>      backtrace output.  */
> 
> Also, as I noted:

I was confusing inside_entry_file and inside_entry_func again.  My
apologies.

I'm still pretty confident that the test was necessary when I added it
to the ARM target, i.e. something broke without it - I remember not
copying and pasting it, but actually going looking for it.  I'll retest
when I get the time.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer