[commit] Eliminate set frame next/prev hack

[Andrew Cagney <cagney at gnu dot org>]

The callers (mcore and mn10300) were were using this to set next/prev to 
NULL, but the frame parameter's prev/next were already null (having just 
been allocated using frame_xmalloc.  This eliminates those redundant calls.

Andrew

PS: "(deprecated_set_frame_prev_hack): Delete function." snuck through 
in an earlier commit I'm fixing the changelog here.
2003-11-22  Andrew Cagney  <cagney@redhat.com>

	* frame.h (deprecated_set_frame_next_hack): Delete declaration.
	(deprecated_set_frame_prev_hack): Delete declaration.
	* frame.c (deprecated_set_frame_next_hack): Delete function.
	(deprecated_set_frame_prev_hack): Delete function.
	* mcore-tdep.c (analyze_dummy_frame): Delete calls to
	"deprecated_set_frame_next_hack" and
	"deprecated_set_frame_prev_hack".
	* mn10300-tdep.c (analyze_dummy_frame): Ditto.

Index: frame.c
===================================================================
RCS file: /cvs/src/src/gdb/frame.c,v
retrieving revision 1.149
diff -u -r1.149 frame.c
--- frame.c	22 Nov 2003 23:00:37 -0000	1.149
+++ frame.c	23 Nov 2003 00:02:43 -0000
@@ -2237,13 +2237,6 @@
   frame->extra_info = extra_info;
 }
 
-void
-deprecated_set_frame_next_hack (struct frame_info *fi,
-				struct frame_info *next)
-{
-  fi->next = next;
-}
-
 struct frame_info *
 deprecated_frame_xmalloc (void)
 {
Index: frame.h
===================================================================
RCS file: /cvs/src/src/gdb/frame.h,v
retrieving revision 1.113
diff -u -r1.113 frame.h
--- frame.h	22 Nov 2003 23:00:37 -0000	1.113
+++ frame.h	23 Nov 2003 00:02:58 -0000
@@ -730,14 +730,6 @@
 extern struct frame_info *deprecated_frame_xmalloc_with_cleanup (long sizeof_saved_regs,
 								 long sizeof_extra_info);
 
-/* FIXME: cagney/2003-01-07: These are just nasty.  Code shouldn't be
-   doing this.  I suspect it dates back to the days when every field
-   of an allocated structure was explicitly initialized.  */
-extern void deprecated_set_frame_next_hack (struct frame_info *fi,
-					    struct frame_info *next);
-extern void deprecated_set_frame_prev_hack (struct frame_info *fi,
-					    struct frame_info *prev);
-
 /* Return non-zero if the architecture is relying on legacy frame
    code.  */
 extern int legacy_frame_p (struct gdbarch *gdbarch);
Index: mcore-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mcore-tdep.c,v
retrieving revision 1.78
diff -u -r1.78 mcore-tdep.c
--- mcore-tdep.c	27 Sep 2003 15:51:02 -0000	1.78
+++ mcore-tdep.c	23 Nov 2003 00:03:06 -0000
@@ -259,8 +259,6 @@
       deprecated_set_frame_extra_info_hack (dummy, extra_info);
     }
 
-  deprecated_set_frame_next_hack (dummy, NULL);
-  deprecated_set_frame_prev_hack (dummy, NULL);
   deprecated_update_frame_pc_hack (dummy, pc);
   deprecated_update_frame_base_hack (dummy, frame);
   get_frame_extra_info (dummy)->status = 0;
Index: mn10300-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mn10300-tdep.c,v
retrieving revision 1.93
diff -u -r1.93 mn10300-tdep.c
--- mn10300-tdep.c	2 Oct 2003 20:28:29 -0000	1.93
+++ mn10300-tdep.c	23 Nov 2003 00:03:13 -0000
@@ -163,8 +163,6 @@
       extra_info = XMALLOC (struct frame_extra_info);
       deprecated_set_frame_extra_info_hack (dummy, extra_info);
     }
-  deprecated_set_frame_next_hack (dummy, NULL);
-  deprecated_set_frame_prev_hack (dummy, NULL);
   deprecated_update_frame_pc_hack (dummy, pc);
   deprecated_update_frame_base_hack (dummy, frame);
   get_frame_extra_info (dummy)->status = 0;