This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: regarding transparent data ranges (in tracepoint support)
- From: Mark Newman <markn_46 at yahoo dot com>
- To: gdb-patches at sources dot redhat dot com, Daniel Jacobowitz <drow at mvista dot com>, "Newman, Mark \(N-Superior Technical Resource Inc\)" <mark dot newman at lmco dot com>
- Cc: ankit thukral <ankit_plug at yahoo dot com>, Jim Blandy <jimb at redhat dot com>, gdb at sources dot redhat dot com
- Date: Fri, 28 Nov 2003 17:29:52 -0800 (PST)
- Subject: Re: regarding transparent data ranges (in tracepoint support)
Here ya go - but I'll be darned if this is clearer.
Mark
Index: gdb/infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.122
diff -r1.122 infrun.c
46a47,48
> #include "cli/cli-decode.h"
>
4007a4010,4011
> async_cmd(stop_command , ASYNC_OK);
>
Index: gdb/maint.c
===================================================================
RCS file: /cvs/src/src/gdb/maint.c,v
retrieving revision 1.40
diff -r1.40 maint.c
737c737
< add_prefix_cmd ("show", class_maintenance,
maintenance_show_cmd, "\
---
> async_cmd ( add_prefix_cmd ("show",
class_maintenance, maintenance_show_cmd, "\
742c742,743
< &maintenancelist);
---
> &maintenancelist)
> , ASYNC_OK);
Index: gdb/top.c
===================================================================
RCS file: /cvs/src/src/gdb/top.c,v
retrieving revision 1.85
diff -r1.85 top.c
671,676c671,673
< if (event_loop_p && target_can_async_p () &&
target_executing)
< if (strcmp (c->name, "help") != 0
< && strcmp (c->name, "pwd") != 0
< && strcmp (c->name, "show") != 0
< && strcmp (c->name, "stop") != 0)
< error ("Cannot execute this command while the
target is running.");
---
> if (event_loop_p && target_can_async_p () &&
target_executing)
> if ((c->flags & ASYNC_OK) != 0)
> error ("Cannot execute this command while
the target is running.");
749a747,754
>
> if (event_loop_p && target_can_async_p () &&
target_executing) {
> if ((c->flags & ASYNC_WAIT) != 0) {
> wait_for_inferior();
> }
> }
>
>
Index: gdb/cli/cli-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/cli/cli-cmds.c,v
retrieving revision 1.36
diff -r1.36 cli-cmds.c
1059,1060c1059,1061
< add_com ("pwd", class_files, pwd_command,
< "Print working directory. This is used for your
program as well.");
---
> async_cmd(add_com ("pwd", class_files,
pwd_command,
> "Print working directory. This is used for your
program as well.")
> , ASYNC_OK);
1093a1095,1096
> async_cmd(c, ASYNC_OK);
>
Index: gdb/cli/cli-decode.c
===================================================================
RCS file: /cvs/src/src/gdb/cli/cli-decode.c,v
retrieving revision 1.34
diff -r1.34 cli-decode.c
1541a1542,1550
> struct cmd_list_element *
> async_cmd (struct cmd_list_element *cmd, int f)
> {
>
> cmd->flags |= f;
>
> return cmd;
> }
>
Index: gdb/cli/cli-decode.h
===================================================================
RCS file: /cvs/src/src/gdb/cli/cli-decode.h,v
retrieving revision 1.17
diff -r1.17 cli-decode.h
51a52,54
> #define ASYNC_OK 0x08
> #define ASYNC_WAIT 0x10
>
--- Daniel Jacobowitz <drow@mvista.com> wrote:
> On Fri, Nov 28, 2003 at 12:31:13PM -0500, Newman,
> Mark (N-Superior Technical Resource Inc) wrote:
> > Thanks Daniel;
> >
> > Any other comments on the async changes?
>
> I asked for you to repost them using some readable
> format. Describing
> changes is both inefficient and ambiguous.
>
> >
> > Mark
> >
> > > -----Original Message-----
> > > From: Daniel Jacobowitz [mailto:drow@mvista.com]
> > > Sent: Friday, November 28, 2003 12:28 PM
> > > To: Newman, Mark (N-Superior Technical Resource
> Inc)
> > > Cc: ankit thukral; Jim Blandy;
> gdb@sources.redhat.com
> > > Subject: Re: regarding transparent data ranges
> (in tracepoint support)
> > >
> > >
> > > On Fri, Nov 28, 2003 at 12:19:12PM -0500,
> Newman, Mark
> > > (N-Superior Technical Resource Inc) wrote:
> > > > Could you be specific as to what kernel/file
> this is in?
> > > >
> > > > I am using 2.4.18 and can't find it in
> kernel/ptrace.c .
> > >
> > > That's your problem. It was added around
> 2.5.38.
> > >
> > > --
> > > Daniel Jacobowitz
> > > MontaVista Software
> Debian GNU/Linux Developer
> > >
> >
>
> --
> Daniel Jacobowitz
> MontaVista Software Debian
> GNU/Linux Developer