This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Outwit compiler dead code elimination in break.exp test


ff> The messages will now be something like:
ff>   PASS: gdb.base/break.exp: set to-be-silent break bp_location1
ff> instead of:
ff>   PASS: gdb.base/break.exp: set to-be-silent break 83

Mmmmm, a test suite discussion.  Can I throw two cents in?  :)

Either message looks fine to me.  It's important that the message
be unique within the test script, and either message would be unique
within the test script.  And it's important that the message not change
from run to run, and "break 83" does not change from run to run
unless someone actually changes the test script.

So "break 83" wasn't a big problem but "break bp_location1" appeals
more to me esthetically.

Michael C


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]