This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH/RFC] observer tests & GCC 3.4
Date: 11 Dec 2003 16:34:40 +0200
From: Eli Zaretskii <eliz@elta.co.il>
> Date: Thu, 11 Dec 2003 14:55:15 +0100 (CET)
> From: Mark Kettenis <kettenis@chello.nl>
>
> Index: ChangeLog
> from Mark Kettenis <kettenis@gnu.org>
>
> * observer.c (observer_test_first_observer,
> observer_test_second_observer, observer_test_third_observer):
> Don't define as `static'.
> (observer_test_first_notification_function,
> observer_test_second_notification_function,
> observer_test_third_notification_function): Likewise.
Nitpicking: the format of the ChangeLog entries is not according to
standards.texi. (See my other message today, in another thread.)
Oh dear. I've been doing this the wrong way for *years*. I'll try to
be a good boy from now on ;-).
Anyway, I committed the attached.
Mark
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* observer.c (observer_test_first_observer)
(observer_test_second_observer, observer_test_third_observer):
Don't define as `static'.
(observer_test_first_notification_function)
(observer_test_second_notification_function)
(observer_test_third_notification_function): Likewise.
Index: observer.c
===================================================================
RCS file: /cvs/src/src/gdb/observer.c,v
retrieving revision 1.3
diff -u -p -r1.3 observer.c
--- observer.c 18 Mar 2003 18:05:50 -0000 1.3
+++ observer.c 12 Dec 2003 16:09:32 -0000
@@ -191,30 +191,30 @@ observer_notify_normal_stop (void)
generic_observer_notify (normal_stop_subject, NULL);
}
-/* The following code is only used to unit-test the observers from
- our testsuite. DO NOT USE IT within observer.c! */
+/* The following code is only used to unit-test the observers from our
+ testsuite. DO NOT USE IT within observer.c (or anywhere else for
+ that matter)! */
-/* Since this code will not be used within GDB, it will trigger
- a warning if we decide to compile with -Wunused-function.
- This is ok for now. (brobecker 2003-03-18) */
+/* If we define these variables and functions as `static', the
+ compiler will optimize them out. */
-static int observer_test_first_observer = 0;
-static int observer_test_second_observer = 0;
-static int observer_test_third_observer = 0;
+int observer_test_first_observer = 0;
+int observer_test_second_observer = 0;
+int observer_test_third_observer = 0;
-static void
+void
observer_test_first_notification_function (void)
{
observer_test_first_observer++;
}
-static void
+void
observer_test_second_notification_function (void)
{
observer_test_second_observer++;
}
-static void
+void
observer_test_third_notification_function (void)
{
observer_test_third_observer++;