This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Remove some hardwired assumptions about register sets
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Fri, 2 Jan 2004 14:31:46 -0500
- Subject: Re: [PATCH] Remove some hardwired assumptions about register sets
- References: <200312170614.hBH6Ebtl003033@fred.ninemoons.com> <200312221851.10629.fnf@ninemoons.com> <20031223020339.GA13570@nevyn.them.org> <3FF5C642.3000504@gnu.org>
On Fri, Jan 02, 2004 at 02:28:02PM -0500, Andrew Cagney wrote:
> >On Mon, Dec 22, 2003 at 06:51:10PM -0700, Fred Fish wrote:
> >
> >>On Tuesday 16 December 2003 23:14, Fred Fish wrote:
> >
> >>> This patch removes some hard coded assumptions about the sizes of the
> >>> various processor specific register sets, and also allows them to be
> >>> of different sizes if necessary.
> >>>
> >>> Comments?
> >
> >>
> >>Except for my own followup, there haven't been any comments about this
> >>patch.
> >>
> >>I propose that if there are no objections by this weekend that the
> >>patch should be checked in, after the previously noted fix is made of
> >>course.
>
> >I like the patch, for what that's worth.
>
> Daniel, the patch adds a global variable "num_mips_processor_regs" vis:
> ! tdep->mips_processor_reg_names = mips_irix_reg_names;
> ! num_mips_processor_regs = sizeof (mips_irix_reg_names) / sizeof
> (char *);
> and that can't be right :-(
Good lord, I'm not paying enough attention. I'm glad you caught that!
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer