Re: [RFC/dwarf-2] Add support for included files

["Eli Zaretskii" <eliz at elta dot co dot il>]

> Date: Sat, 3 Jan 2004 15:42:50 +0100
> From: Joel Brobecker <brobecker@gnat.com>
> 
> Eli Zaretskii wrote:
> > How about if we only do that scan when the file name is not found in
> > the partial symbols, i.e. just before GDB is about to give up and
> > report the file as nonexistent?  Assuming that the cases you have in
> > mind are rare, this would mean faster operation in most cases.
> 
> I am a bit relunctant to go that way, because I think the current
> approach of using a half-baked psymtabs to hold include files is
> a bit too adhoc for my taste. Adding an extra step after having scanned
> the psymtab list to iterate over all objfiles, and re-partially scan the
> debugging information seems to be going one step further in
> ``legitimizing'' this adhoc approach.

I made that suggestion because it sounded like the addition you made
caused some percepted slow-down of the psymtab scan.  If that is not
true, consider my reservations to be withdrawn.

In other words, I would also like to see some measurements, as you
say:

> It seems a bit of effort for a gain that we haven't measured.
> I would suggest going the simple way first and re-think it if
> the performance becomes noticeably worse. If somebody has a large
> app like mozilla that he can use to do some measurement, I would
> sure appreciate how much slower it is to startup with the patch
> I posted.

Perhaps even a not-so-behemoth example would do fine.