Re: [PATCH] segv fix when eof is typed in actions

[Michael Snyder <msnyder at redhat dot com>]

PaweÄï Ostrowski wrote:
> Dnia Mon, Jan 05, 2004 at 05:13:58PM -0800, Michael Snyder napisaÅ(a):
>
> > > GDB (snapshot 20031230) segfaults on the following script (and on any
> > > program being debugged: int main() {return 0;} is enough):
> > >
> > > trace main
> > > actions 1
> > > <EOF here>
> > >
> > > I have found out that typing EOF when editing tracepoint actions
> > > causes gdb to segv. The segv is caused by dereferencing twice line
> > > parameter (**line), when *line is NULL. I have added check for this
> > > case to validate_actionline() in tracepoint.c, so it now ends actions
> > > editing (just like you would have typed "end" instead of EOF).
> > >
> > > Some details of my configuration:
> > > - gdb versions: 6.0, 20031230 snapshot, both compiled with gcc 3.3.2
> > > - uname -rmpo: 2.6.0 i686 AMD_Athlon(tm)_XP_1500+ PLD Linux
> >
> > Approved -- want me to check it in for you?
>
>
> Yes, please. I will be obliged for helping me in this matter.

Committed.