This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[rfc, rfa:doco] Add -Wunused-label to -Werror list
- From: Andrew Cagney <cagney at gnu dot org>
- To: gdb-patches at sources dot redhat dot com,Eli Zaretskii <eliz at is dot elta dot co dot il>
- Date: Sun, 11 Jan 2004 11:58:48 -0500
- Subject: [rfc, rfa:doco] Add -Wunused-label to -Werror list
Hello,
This adds -Wunused-label to the list of -W flags that GDB is compiled
against. I believe that GDB is now clean.
Eli, doco look ok?
Andrew
2004-01-11 Andrew Cagney <cagney@redhat.com>
* configure.in (build_warnings): Add -Wunused-label.
* configure: Re-generate.
Index: doc/ChangeLog
2004-01-11 Andrew Cagney <cagney@redhat.com>
* gdbint.texinfo (Coding): Add -Wunused-label to list of -Werror
warnings.
Index: configure.in
===================================================================
RCS file: /cvs/src/src/gdb/configure.in,v
retrieving revision 1.138
diff -u -r1.138 configure.in
--- configure.in 2 Jan 2004 12:40:08 -0000 1.138
+++ configure.in 11 Jan 2004 16:54:44 -0000
@@ -1024,9 +1024,10 @@
# NOTE: If you add to this list, remember to update
# gdb/doc/gdbint.texinfo.
build_warnings="-Wimplicit -Wreturn-type -Wcomment -Wtrigraphs \
--Wformat -Wparentheses -Wpointer-arith -Wuninitialized -Wformat-nonliteral"
+-Wformat -Wparentheses -Wpointer-arith -Wuninitialized -Wformat-nonliteral \
+-Wunused-label"
# Up for debate: -Wswitch -Wcomment -trigraphs -Wtrigraphs
-# -Wunused-function -Wunused-label -Wunused-variable -Wunused-value
+# -Wunused-function -Wunused-variable -Wunused-value
# -Wchar-subscripts -Wtraditional -Wshadow -Wcast-qual
# -Wcast-align -Wwrite-strings -Wconversion -Wstrict-prototypes
# -Wmissing-prototypes -Wmissing-declarations -Wredundant-decls
Index: doc/gdbint.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v
retrieving revision 1.178
diff -u -r1.178 gdbint.texinfo
--- doc/gdbint.texinfo 10 Nov 2003 22:47:31 -0000 1.178
+++ doc/gdbint.texinfo 11 Jan 2004 16:54:56 -0000
@@ -5132,6 +5132,22 @@
@item -Wpointer-arith
@item -Wuninitialized
+
+@item -Wunused-label
+This warning has the additional benefit of detecting the coding error:
+@smallexample
+enum @{ FD_SCHEDULED, NOTHING_SCHEDULED @} sched;
+@dots{}
+switch (sched)
+ @{
+ case FD_SCHEDULED:
+ @dots{};
+ break;
+ NOTHING_SCHEDULED:
+ @dots{};
+ break;
+ @}
+@end smallexample
@end table
@emph{Pragmatics: Due to the way that @value{GDBN} is implemented most