This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[obish/cris] Delete extract_struct_value_address


Orjan,

The attached deletes cris's implementation of extract_struct_value_address. Knowing two things make deleting it relatively obvious:

- infrun.c's been rewritten so that it never calls extract_struct_value_address, hence the "trick" of saving the return value's address in a global is never exploited

- as the comments note, the ABI doesn't preserve the return address register and hence the other potential caller (code trying to extract the return value) doesn't apply

BTW, suggest looking at "return_value", implementing it has a dramatic effect on the test results from structs.exp.

enjoy, (committed)
Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]