Re: [RFA] Fix testsuite gdb.base/bang.exp to work with remote targets

[Daniel Jacobowitz <drow at mvista dot com>]

On Mon, Feb 02, 2004 at 01:56:34PM -0700, Fred Fish wrote:
> On Monday 02 February 2004 13:32, Daniel Jacobowitz wrote:
> > How about gdb_run_cmd?
> 
> Initially I tried that and had some problems, but I just went back and tried
> the following:
> 
>   gdb_run_cmd
>   gdb_expect {
>     -re ".*Program exited normally\." {
>         pass "run program"
>     }
>    timeout {
>         fail "run program (timeout)"
>     }
>   }

I would prefer this.  It also handles gdbserver correctly (restart the
server, continue).

> which worked:
> 
>   (gdb) jump *start
>   No symbol "start" in current context.
>   (gdb) jump *_start
>   Continuing at 0x1016.
>   0
>  
>   *** EXIT code 0
>  
>   Program exited normally.
>   PASS: gdb.base/bang.exp: run program
> 
> I'm not sure what happened the first time I tried gdb_run_cmd.
> 
> However, there is some precedence for just checking use_gdb_stub to
> decide whether to "run" or "continue" as there are several other
> places in the testsuite where this is done.  Though it could be argued
> that perhaps they should be converted to use gdb_run_cmd also.

Well, presumably you want to say "continue", because you know we're at
the beginning.  But for some targets (at least, once upon a time, based
on gdb_run_cmd), this wasn't enough.  If you want to preserve the
use-continue version, please work with the utility functions in
gdb.exp, rather than hardcoding more continues in the testsuite.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer