Re: [RFA] sh-tdep.c: optimize fv_reg_base_num and dr_reg_base_num

[Elena Zannoni <ezannoni at redhat dot com>]

Corinna Vinschen writes:
 > Hi,
 > 
 > another optimization which also will simplify the handling of the
 > upcoming SH variant.
 > 
 > The functions fv_reg_base_num and dr_reg_base_num are basically
 > one-liner.  The expression they evaluate is fairly simple so
 > I'd suggest the following patch.  It converts both functions
 > into macros which will be evaluated inline.  This has the additional
 > advantage, that the functions in which they are called have access
 > to gdbarch, which comes in handy for the new SH variant.
 > 
 > If the conversion into macros is undesired, I'd like to suggest an
 > alternative implementation.  In that case I'd like to add gdbarch as
 > first parameter to both functions.

I prefer to not introduce macros here.  Can you explain where you are
headed? This looks like a micro optimization and I don't see the point
of it ATM.