This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Cleanup i386-nat.c
- From: Eli Zaretskii <eliz at elta dot co dot il>
- To: Mark Kettenis <kettenis at chello dot nl>
- Cc: gdb-patches at sources dot redhat dot com
- Date: 29 Feb 2004 08:06:56 +0200
- Subject: Re: [PATCH] Cleanup i386-nat.c
- References: <200402281538.i1SFcNds012429@elgar.kettenis.dyndns.org>
- Reply-to: Eli Zaretskii <eliz at elta dot co dot il>
> Date: Sat, 28 Feb 2004 16:38:23 +0100 (CET)
> From: Mark Kettenis <kettenis@chello.nl>
>
> The coding style in this file had some quirks, so I committed the
> attached.
That's largely my code, so please explain the changes, so that I
never repeat any mistakes I've committed. I've read the entire
patch, and I must say that I don't understand even a single change
you made. In the comments reformatting department, I guess we have
different setting for fill-column (what is the canonical one, btw?),
but as for the rest, I don't have a clue. So please do explain.
> - /* Four(eigth on x86_64) is the maximum length an x86 debug register
> + int align = addr % max_wp_len;
> + /* Four (eigth on AMD64) is the maximum length a debug register
Here, there's a real typo in the comment, but it wasn't fixed.