This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] ia64-unknown-freebsd
- From: Mark Kettenis <kettenis at chello dot nl>
- To: marcel at xcllnt dot net, kevinb at redhat dot com
- Cc: gdb-patches at sources dot redhat dot com
- Date: Thu, 25 Mar 2004 12:45:22 +0100 (CET)
- Subject: Re: [PATCH] ia64-unknown-freebsd
- References: <20040325091159.GB87599@dhcp01.pn.xcllnt.net>
Date: Thu, 25 Mar 2004 01:11:59 -0800
From: Marcel Moolenaar <marcel@xcllnt.net>
Marcel, do you have a copyright assignment with the FSF for GDB?
Without it we can't use your code :-(. Does this code give some
reasonable testsuite results? Does it support calling functions from
within GDB? I never got that working when I was hacking on this.
Kevin. What's the status of AIX on IA-64? Isn't it completely dead?
Anyway, Marcel, here are some hints:
* Get rid of the xm-fbsd.h file.
* For the nm-fbsd.h file, I recently factored out some common *BSD
things. Also, please move the shared library support stuff to
tm-fbsd.h. All you need there is to include "solib.h". The
inclusion of "elf/common.h" and the SVR4_SHARED_LIBS shouldn't be
necessary anymore. This also means you'll want to move solib.o and
solib-svr4.o from fbsd.mh to fbsd.mt. You can drop solib-legacy.o
if you add:
set_solib_svr4_fetch_link_map_offsets
(gdbarch, svr4_lp64_fetch_link_map_offsets);
to ia64-fbsd-tdep.c:ia64_fbsd_init_abi().
* The code that deals with the registers (taking apart `struct reg'
and `struct fpreg') shouldn't live in ia64-fbsd-nat.c, but in
ia64-fbs-tdep.c. This involves hard coding the offsets of the
various registers.
* There are various coding-style issues. Mostly this involves the
formatting of comments, but there are also GCC-isms like __inline
that will have to dissappear.
That said, I think you're on the right track with TARGET_OBJECT_DIRTY.
Mark