This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
I was triple checking that I fail gracefully if we don't find any gnatmake program when running our new ada tescase, and that part seems fine. But, on the contrary, I think we're being perhaps a little too silent. Right now, if you don't run the null_record.exp testcase with -v, the entire test gets skipped without any message (ie no compilation error message, no pass, no fail). With -v, we get: << Ada compilation failed: default_target_compile: Can't find gnatmake. >> That's because in null_record.exp, I have put: if {[gdb_compile_ada <bla bla bla>] != "" } { !! -> return -1 } So indeed, when gdb_compile_ada fails, I simply abort the test... A bit too extreme, maybe? :-). Anyway, I looked at various tests in the gdb.base and gdb.cp subdirectory, and found that the common thing to do something like this: gdb_suppress_entire_file "Testcase compile failed, [...]" Here is the output (not very pretty, but oh well) I get after using this procedure, instead of returning prematurely: << WARNING: Testcase compile failed, so all tests in this file will automatically fail. ERROR: (timeout) GDB never initialized after 10 seconds. WARNING: remote_expect statement without a default case?! ERROR: couldn't load /home/brobecke/act/gdb-public/gdb/testsuite/gdb.ada/null_record into /home/brobecke/act/gdb-public/gdb/testsuite/../../gdb/gdb (end of file). FAIL: gdb.ada/null_record.exp: ptype on null record >> Note that the logs still do not contain the reason for the failure. The reason is only printed if I run the testcase with -v. 2004-03-31 Joel Brobecker <brobecker@gnat.com> * gdb.ada/null_record.exp: Do not abort the test prematurely if the build of the example program failed. Report a warning and automatically fail the tests in that file. Tested on x86-linux. OK to apply? Thanks, -- Joel
Attachment:
null_record.exp.diff
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |