This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[obish] Delete DEPRECATED_INIT_FRAME_PC_FIRST
- From: Andrew Cagney <cagney at gnu dot org>
- To: gdb-patches at sources dot redhat dot com
- Date: Fri, 02 Apr 2004 17:59:56 -0500
- Subject: [obish] Delete DEPRECATED_INIT_FRAME_PC_FIRST
FYI,
It's never set. Committed.
Andrew
2004-04-02 Andrew Cagney <cagney@redhat.com>
* gdbarch.sh (DEPRECATED_INIT_FRAME_PC_FIRST): Delete.
* gdbarch.h, gdbarch.c: Re-generate.
* frame.c (legacy_get_prev_frame): Delete references to
DEPRECATED_INIT_FRAME_PC_FIRST.
Index: frame.c
===================================================================
RCS file: /cvs/src/src/gdb/frame.c,v
retrieving revision 1.169
diff -u -r1.169 frame.c
--- frame.c 2 Apr 2004 20:21:07 -0000 1.169
+++ frame.c 2 Apr 2004 22:58:02 -0000
@@ -1268,7 +1268,7 @@
}
/* Create the previous frame using the deprecated methods
- INIT_EXTRA_INFO, INIT_FRAME_PC and INIT_FRAME_PC_FIRST. */
+ INIT_EXTRA_INFO, and INIT_FRAME_PC. */
static struct frame_info *
legacy_get_prev_frame (struct frame_info *this_frame)
@@ -1304,8 +1304,7 @@
/* NOTE: cagney/2002-11-18: Should have been correctly setting the
frame's type here, before anything else, and not last, at the
bottom of this function. The various
- DEPRECATED_INIT_EXTRA_FRAME_INFO, DEPRECATED_INIT_FRAME_PC,
- DEPRECATED_INIT_FRAME_PC_FIRST and
+ DEPRECATED_INIT_EXTRA_FRAME_INFO, DEPRECATED_INIT_FRAME_PC, and
DEPRECATED_FRAME_INIT_SAVED_REGS methods are full of work-arounds
that handle the frame not being correctly set from the start.
Unfortunately those same work-arounds rely on the type defaulting
@@ -1563,10 +1562,6 @@
machines appear to require DEPRECATED_INIT_EXTRA_FRAME_INFO
before they can do DEPRECATED_INIT_FRAME_PC. Phoo.
- We shouldn't need DEPRECATED_INIT_FRAME_PC_FIRST to add more
- complication to an already overcomplicated part of GDB.
- gnu@cygnus.com, 15Sep92.
-
Assuming that some machines need DEPRECATED_INIT_FRAME_PC after
DEPRECATED_INIT_EXTRA_FRAME_INFO, one possible scheme:
@@ -1622,11 +1617,6 @@
frame_pc_unwind() and that function does have somewhere to cache
that PC value. */
- if (DEPRECATED_INIT_FRAME_PC_FIRST_P ())
- deprecated_update_frame_pc_hack (prev,
- DEPRECATED_INIT_FRAME_PC_FIRST (fromleaf,
- prev));
-
if (DEPRECATED_INIT_EXTRA_FRAME_INFO_P ())
DEPRECATED_INIT_EXTRA_FRAME_INFO (fromleaf, prev);
@@ -2322,7 +2312,6 @@
legacy_frame_p (struct gdbarch *current_gdbarch)
{
if (DEPRECATED_INIT_FRAME_PC_P ()
- || DEPRECATED_INIT_FRAME_PC_FIRST_P ()
|| DEPRECATED_INIT_EXTRA_FRAME_INFO_P ()
|| DEPRECATED_FRAME_CHAIN_P ())
/* No question, it's a legacy frame. */
Index: gdbarch.sh
===================================================================
RCS file: /cvs/src/src/gdb/gdbarch.sh,v
retrieving revision 1.305
diff -u -r1.305 gdbarch.sh
--- gdbarch.sh 23 Mar 2004 15:16:41 -0000 1.305
+++ gdbarch.sh 2 Apr 2004 22:58:03 -0000
@@ -563,7 +563,6 @@
# migration process - old code, calling DEPRECATED_PC_IN_CALL_DUMMY(),
# doesn't need to be modified.
F::DEPRECATED_PC_IN_CALL_DUMMY:int:deprecated_pc_in_call_dummy:CORE_ADDR pc, CORE_ADDR sp, CORE_ADDR frame_address:pc, sp, frame_address::deprecated_pc_in_call_dummy:deprecated_pc_in_call_dummy
-F:2:DEPRECATED_INIT_FRAME_PC_FIRST:CORE_ADDR:deprecated_init_frame_pc_first:int fromleaf, struct frame_info *prev:fromleaf, prev
F:2:DEPRECATED_INIT_FRAME_PC:CORE_ADDR:deprecated_init_frame_pc:int fromleaf, struct frame_info *prev:fromleaf, prev
#
v:2:BELIEVE_PCC_PROMOTION:int:believe_pcc_promotion:::::::