Re: [RFC/dwarf-2] Add support for included files

[Joel Brobecker <brobecker at gnat dot com>]

Hello Jim,

> If you add a comment above dwarf_decode_lines explaining how it's
> called, and that PST determines whether we're building psymtabs or
> symtabs, we'll call it even.
> 
> I just approved Daniel's mondo psymtab construction patch, so one of
> you is going to get in the others' way.  Have fun.

Here is an updated version of the previous patch, adapted to fit in
the current dwarf2read.c after Daniel's changes, and with comments
added. It's actually slightly smaller thanks to Daniel's changes :-).

2004-04-16  Joel Brobecker  <brobecker@gnat.com>

        * dwarf2read.c (dwarf2_create_include_psymtab): New function.
        (dwarf2_build_include_psymtabs): New function.
        (read_partial_die): Add new parameter.
        (add_file_name): Add forward declaration.
        (dwarf_decode_lines): Add new parameter. Enhance this procedure
        to be able to determine the list of files included by the
        given unit, and build their associated psymtabs.
        (dwarf2_build_psymtabs_hard): Build the psymtabs for the
        included files as well.
        (psymtab_to_symtab_1): Build the symtabs of all dependencies
        as well.
        (read_file_scope): Update call to read_partial_die.
        (load_partial_dies): Likewise.

Tested on x86-linux. No regression, and it fixes the following two
KFAILs:

        KFAIL: gdb.base/sep.exp: list using location inside included file
               (PRMS: symtab/1607)
        KFAIL: gdb.base/sep.exp: breakpoint inside included file
               (PRMS: symtab/1607)

If this patch is approved, I'll send another one removing the setup_kfails.

Thanks,
-- 
Joel

Attachment: separate.diff
Description: Text document