Re: [patch] Fix unwind handling for hppa

[Randolph Chung <randolph at tausq dot org>]

> > +    if (frame_relative_level (next_frame) >= 0 || 
> > +        frame_pc_unwind (next_frame) >= 
> > +	hppa_skip_prologue (frame_func_unwind (next_frame)))
> 
>   - your formatting is wrong; operators always come at the beginning
>     of the line.

ok, i have to go and read the coding style doc some more since it is
very different from what i'm used to :)

>   - Checking the frame level is wrong.  It's wrong both in practice and
>     in principle: in practice, the next frame could be a dummy frame
>     or a signal frame.  There's a test case in the testsuite which
>     covers this.

mmmm, ok. so if i just do:

    if (frame_pc_unwind (next_frame) 
        >= hppa_skip_prologue (frame_func_unwind (next_frame)))

then it's ok? or is there a more efficient/correct mechanism to get to 
this info?

thanks,
randolph
-- 
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/