This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: handling of absolute source file paths


> Date: Tue, 20 Apr 2004 18:48:57 +0300
> From: Baurjan Ismagulov <ibr@ata.cs.hun.edu.tr>
> 
> considering http://sources.redhat.com/gdb/current/onlinedocs/gdb_8.html
> , I expect the following behaviour:

Actually, the manual doesn't describe what happens in the specific
case you are talking about: it says

  Each time GDB wants a source file, it tries all the directories in
  the list, in the order they are present in the list, until it finds
  a file with the desired name

Note that it doesn't specify what happens if the file's name starts
with a slash or otherwise has leading directories.  It would be good
to augment the manual with a more explicit description of cases such
as yours.  Would you like to do that?

> However, due to a change discussed in
> http://sources.redhat.com/ml/gdb/2004-01/msg00243.html , gdb isn't able
> to find the source even after the "directory" command; I consider this
> to be a bug. We've implemented the change proposed in
> http://sources.redhat.com/ml/gdb/2004-03/msg00026.html . The patched
> version behaves the same for binaries, but finds the sources if the
> "directory" command was issued.

First, please in the future send patches as plain text, not as
compressed binary attachments; that might help your patches to be
reviewed sooner.

> I suggest that it is included for stable and unstable branches. What do
> you think?

The patch looks good to me, and I think I can approve it (Andrew?).
So, unless someone else objected, it can go in.  However,

> I consider this patch to be not legally significant. Please inform me if
> you need a copyright assignment.

I don't know if you need an assignment for this patch, so I'll let
others to give you a definitive answer.

Thanks!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]