[commit] Default to generic_save_dummy_frame_tos

[Andrew Cagney <cagney at gnu dot org>]

Hello,

This modifies infrun.c so that it uses generic_save_dummy_frame_tos 
unless DEPRECATED_SAVE_DUMMY_FRAME_TOS is supplied.

As obvious fallout, it updates any architectures unnecessarially setting 
DEPRECATED_SAVE_DUMMY_FRAME_TOS to generic_save_dummy_frame_tos.  This 
leaves us with just the xstormy16 still setting that deprecated method.

committed,
Andrew

2004-05-08  Andrew Cagney  <cagney@redhat.com>

	* infcall.c (call_function_by_hand): When no
	DEPRECATED_SAVE_DUMMY_FRAME_TOS call generic_save_dummy_frame_tos.
	* rs6000-tdep.c (rs6000_gdbarch_init): Do not set
	DEPRECATED_SAVE_DUMMY_FRAME_TOS.
	* mn10300-tdep.c (mn10300_gdbarch_init): Ditto.
	* mcore-tdep.c (mcore_gdbarch_init): Ditto.
	
Index: infcall.c
===================================================================
RCS file: /cvs/src/src/gdb/infcall.c,v
retrieving revision 1.46
diff -p -u -r1.46 infcall.c
--- infcall.c	8 May 2004 21:52:50 -0000	1.46
+++ infcall.c	8 May 2004 22:16:31 -0000
@@ -721,15 +721,13 @@ You must use a pointer to function type 
   if (DEPRECATED_DUMMY_WRITE_SP_P ())
     DEPRECATED_DUMMY_WRITE_SP (sp);
 
-  if (gdbarch_unwind_dummy_id_p (current_gdbarch))
-    {
-      /* Sanity.  The exact same SP value is returned by
-	 PUSH_DUMMY_CALL, saved as the dummy-frame TOS, and used by
-	 unwind_dummy_id to form the frame ID's stack address.  */
-      generic_save_dummy_frame_tos (sp);
-    }
-  else if (DEPRECATED_SAVE_DUMMY_FRAME_TOS_P ())
+  if (DEPRECATED_SAVE_DUMMY_FRAME_TOS_P ())
     DEPRECATED_SAVE_DUMMY_FRAME_TOS (sp);
+  else
+    /* Sanity.  The exact same SP value is returned by
+       PUSH_DUMMY_CALL, saved as the dummy-frame TOS, and used by
+       unwind_dummy_id to form the frame ID's stack address.  */
+    generic_save_dummy_frame_tos (sp);
 
   /* Now proceed, having reached the desired place.  */
   clear_proceed_status ();
Index: mcore-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mcore-tdep.c,v
retrieving revision 1.87
diff -p -u -r1.87 mcore-tdep.c
--- mcore-tdep.c	8 May 2004 21:27:02 -0000	1.87
+++ mcore-tdep.c	8 May 2004 22:16:41 -0000
@@ -1055,7 +1055,6 @@ mcore_gdbarch_init (struct gdbarch_info 
 
   /* Call Dummies:  */
 
-  set_gdbarch_deprecated_save_dummy_frame_tos (gdbarch, generic_save_dummy_frame_tos);
   set_gdbarch_deprecated_saved_pc_after_call (gdbarch, mcore_saved_pc_after_call);
   set_gdbarch_breakpoint_from_pc (gdbarch, mcore_breakpoint_from_pc);
   set_gdbarch_deprecated_push_return_address (gdbarch, mcore_push_return_address);
Index: mn10300-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mn10300-tdep.c,v
retrieving revision 1.104
diff -p -u -r1.104 mn10300-tdep.c
--- mn10300-tdep.c	8 May 2004 21:27:02 -0000	1.104
+++ mn10300-tdep.c	8 May 2004 22:16:46 -0000
@@ -1189,7 +1189,6 @@ mn10300_gdbarch_init (struct gdbarch_inf
   set_gdbarch_deprecated_reg_struct_has_addr
     (gdbarch, mn10300_reg_struct_has_addr);
   set_gdbarch_deprecated_push_return_address (gdbarch, mn10300_push_return_address);
-  set_gdbarch_deprecated_save_dummy_frame_tos (gdbarch, generic_save_dummy_frame_tos);
   set_gdbarch_use_struct_convention (gdbarch, mn10300_use_struct_convention);
 
   tdep->am33_mode = am33_mode;
Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.196
diff -p -u -r1.196 rs6000-tdep.c
--- rs6000-tdep.c	5 May 2004 01:46:55 -0000	1.196
+++ rs6000-tdep.c	8 May 2004 22:16:55 -0000
@@ -2904,7 +2904,6 @@ rs6000_gdbarch_init (struct gdbarch_info
       frame_base_append_sniffer (gdbarch, rs6000_frame_base_sniffer);
       break;
     default:
-      set_gdbarch_deprecated_save_dummy_frame_tos (gdbarch, generic_save_dummy_frame_tos);
       set_gdbarch_believe_pcc_promotion (gdbarch, 1);
 
       set_gdbarch_unwind_pc (gdbarch, rs6000_unwind_pc);