This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: remove meaningless code in ppc-bdm.c
- From: Jim Blandy <jimb at redhat dot com>
- To: Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: 11 May 2004 01:13:11 -0500
- Subject: Re: RFA: remove meaningless code in ppc-bdm.c
- References: <vt2pt9bvr42.fsf@zenia.home> <20040510223831.4cddda8a@saguaro>
Kevin Buettner <kevinb@redhat.com> writes:
> On 10 May 2004 17:45:17 -0500
> Jim Blandy <jimb@redhat.com> wrote:
>
> > I was going through this trying to keep it up to date with the
> > register numbering changes I was making, but then I realized it was
> > complete jibberish. First, the register contents are binary data; you
> > can't strcat them. Second, you can't strcat them into a fixed-size
> > buffer that is already filled with non-zero bytes.
> >
> > 2004-05-10 Jim Blandy <jimb@redhat.com>
> >
> > * ppc-bdm.c (bdm_ppc_fetch_registers): Replace utterly broken code
> > with a call to internal_error.
>
> Okay.
Committed, thanks.