This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: new gdb remote packet type
- From: Daniel Jacobowitz <drow at false dot org>
- To: Andrew Cagney <cagney at gnu dot org>
- Cc: Robert Picco <Robert dot Picco at hp dot com>, gdb-patches at sources dot redhat dot com
- Date: Wed, 12 May 2004 14:30:56 -0400
- Subject: Re: new gdb remote packet type
- References: <407F2BAB.4060408@hp.com> <40802711.3040104@gnu.org> <4087E8C0.30806@hp.com> <4087EE4B.4010805@gnu.org> <40912015.7070902@hp.com> <40928D64.8010209@gnu.org> <4097D9DE.2030004@hp.com> <40993C21.1040500@gnu.org> <409A95AB.6020101@hp.com> <40A26AF4.4050001@gnu.org>
On Wed, May 12, 2004 at 02:20:36PM -0400, Andrew Cagney wrote:
> Yes, this is the key, use it conditionally, nice.
>
> >+ switch (remote_protocol_p.support)
> >+ {
> >+ case PACKET_DISABLE:
> >+ break;
> >+ case PACKET_ENABLE:
> >+ if (fetch_register_using_p (regnum))
> >+ return;
> >+ else
> >+ error ("Protocol error: p packet not recognized by stub");
> >+ case PACKET_SUPPORT_UNKNOWN:
> >+ if (fetch_register_using_p (regnum))
> >+ {
> >+ /* The stub recognized the 'p' packet. Remember this. */
> >+ remote_protocol_p.support = PACKET_ENABLE;
> >+ return;
> >+ }
> >+ else
> >+ {
> >+ /* The stub does not support the 'P' packet. Use 'G'
> >+ instead, and don't try using 'P' in the future (it
> >+ will just waste our time). */
> >+ remote_protocol_p.support = PACKET_DISABLE;
> >+ break;
> >+ }
> >+ }
> >
> > sprintf (buf, "g");
This patch (if 'p' were implemented for gdbserver; I have this lying
around, as it happens) would make register fetches default to using
individual 'p' packets for every register; this would hurt latency, a
lot.
Robert, wouldn't it be good enough for you to work with
!reg->in_g_packet?
--
Daniel Jacobowitz