This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commited] small changes to fix hpux-cc compile


   Date: Sun, 16 May 2004 06:12:23 -0400 (EDT)
   From: mec.gnu@mindspring.com (Michael Elizabeth Chastain)

   Hi Randolph,

   In this change:

     -  char dld_flags_buffer[TARGET_INT_BIT / TARGET_CHAR_BIT];
     +  char dld_flags_buffer[4];

   I just ran into the same problem with TARGET_INT_BIT so I understand
   why this needs to change.  But why 4?  What if the target configuration
   has 64-bit ints?

The question should be: will there ever be a target that uses SOM that
doesn't use 32-bit ints?  I think we can be fairly certain that there
won't be such target in the future.  HP already has abandoned SOM in
favour of ELF of 64-bit HP-UX, and even that still has 32-bit ints.
As a matter of fact, I'm not aware of any ABI that has 64-bit ints.
But in general:

   How about this instead:

     char * dld_flags_buffer = alloca(TARGET_INT_BIT/TARGET_CHAR_BIT);

This is indeed the right approach.

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]