This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/RFC] New command: ``start''


On Thu, May 20, 2004 at 03:12:14PM -0700, Joel Brobecker wrote:
> OK, here is a new patch for the "start" command. I don't need to modify
> main_name() right now, so I left it out of this patch.
> 
> When Ada support is activated, then the next step will be to add the
> new-executable notification, and add a call to the ada_main_name
> routine in main_name(). I am attaching a patch to symtab.c for
> illustration.

This looks pretty good.  I have one question:

> +  /* Check that there is a program to debug.  Some languages such as Ada
> +     need to search inside the program symbols for the location where to
> +     put the temporary breakpoint before starting.  */
> +  if (!have_full_symbols () && !have_partial_symbols ())
> +    error ("No symbol table loaded.  Use the \"file\" command.");

Shouldn't you accept have_minimal_symbols here?


-- 
Daniel Jacobowitz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]