This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [trivial] remove references to add_setshow_cmd_full fromarm-tdep.c
- From: Richard Earnshaw <rearnsha at gcc dot gnu dot org>
- To: Ramana Radhakrishnan <ramana dot radhakrishnan at codito dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 30 Jul 2004 16:58:25 +0100
- Subject: Re: [trivial] remove references to add_setshow_cmd_full fromarm-tdep.c
- Organization: GNU
- References: <410A68AE.2090004@codito.com>
On Fri, 2004-07-30 at 16:26, Ramana Radhakrishnan wrote:
> Hi ,
> While attempting to build cvs head now for arm-elf I ran into a problem
> with add_setshow_cmd_full for apcs32. It has been made
> static in cli-decode.c . Someone has corrected the call but not removed
> the reference . So here goes.
>
> This patch removes the reference. Below the call to add_setshow_cmd_full
> and a call to add_setshow_cmd_boolean is present below. Ok to apply ?
>
> cheers
> Ramana
>
This isn't correct.
1) No ChangeLog entry
2) It's adding code, yet you claim you're removing code.
3) (assuming the patch is inverted somehow) It removes the
initialization of new_set and new_show, but you've left the subsequent
deprecate_cmd calls.
R.