This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] s/PTRACE_ARG3_TYPE/PTRACE_TYPE_ARG3/g ?


Mark,

Should PTRACE_TYPE_ARG[36] include paren vis:

#define PTRACE_TYPE_ARG3 (caddr_t)

configure now automatically detects the type of arg3 in ptrace,
and sets PTRACE_TYPE_ARG3. But the code mostly uses the historical
PTRACE_ARG3_TYPE. I suggest we do a global search-and-replace of
the latter by the former. There are a bunch of C file that use
the old macro. Once the macro is gone, we can delete their definitions
in the config files as an obvious change.

Agreed, both moves are pretty obvious (provided the teathing problems are resolved).


Andrew

Opinions?

List of C files that use it:

        alphabsd-nat.c
        amd64bsd-nat.c
        armnbsd-nat.c
        gdbserver/linux-low.c
        hppabsd-nat.c
        hppah-nat.c
        i386bsd-nat.c
        ia64-linux-nat.c
        inferior.h
        infptrace.c
        inftarg.c
        infttrace.c
        infttrace.h
        linux-nat.c
        lynx-nat.c
        m68kbsd-nat.c
        m68klinux-nat.c
        m88kbsd-nat.c
        mipsnbsd-nat.c
        ns32knbsd-nat.c
        ppc-linux-nat.c
        ppcnbsd-nat.c
        ppcobsd-nat.c
        shnbsd-nat.c
        sparc-nat.c
        vaxbsd-nat.c

List of config files that define it:

        config/alpha/nm-linux.h
        config/alpha/nm-osf.h
        config/i386/nm-linux64.h
        config/ia64/nm-linux.h
        config/mips/nm-linux.h
        config/nm-bsd.h
        config/nm-lynx.h
        config/nm-nbsd.h
        config/pa/nm-hppah.h
        config/powerpc/nm-aix.h
        config/powerpc/nm-ppc64-linux.h
        config/rs6000/xm-aix4.h
        config/s390/nm-linux.h
        config/sparc/nm-linux.h

Unfortunately, I will probably not be around to make that change.
But this is the kind of change a guy named cagney has become an expert
at doing. :-).

And we also need to remove it from the gdbint doc, btw.

-- Joel



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]