This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [testsuite] Kfail signals.exp failures



Perhaps we should move all the signals tests to a new subdirectory
gdb.signal, and delegate someone else to be senior maintainer for
that subdirectory?  I would feel competent to be junior maintainer.

Well, you're actually doing your job to a tee. You made a decision based on the best available information, and then when more information came to light, revised the decision, and learn't from the experience :-)


(I've now posted fixes to both signals.exp and sigstep.exp)

As for a separate signals directory, this code is really testing infrun.c (ya), and makes for some fundamental functionality (should have been fixed working 10+ years ago), so I think still belongs in gdb.base. Besides I've been naming all the files sig*.exp so that they are easy to identify.

I think its better to reserve new directories for things that are clearly separate -> stabs edge cases, dwarf edge cases, C++ lang stuff, ... We could too easily end up with a pedantic debate over which directory a test belongs (...) :-)

If we don't do that, then I'm going to try something new in gdb
maintainership: delegation.  I'll ask for 2 or 3 expert volunteers,
and I'll approve a signals patch just when there's unanimous consent
among the experts.

And I've made a note to read up on signals tests.

Andrew




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]