This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch/rfc] Implement ptrace target vector inheritance
- From: "Eli Zaretskii" <eliz at gnu dot org>
- To: Andrew Cagney <cagney at gnu dot org>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 06 Sep 2004 07:58:35 +0300
- Subject: Re: [patch/rfc] Implement ptrace target vector inheritance
- References: <413B1E60.9060506@gnu.org>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Sun, 05 Sep 2004 10:10:40 -0400
> From: Andrew Cagney <cagney@gnu.org>
>
> The current native code constructs its target vector using a convoluted
> combination of #ifdefs and global functions.
>
> This patch replaces all that with what is effectively a runtime
> inheritance structure:
>
> inf-ptrace is-a inf-child is-a target
>
> I've updated/tested NetBSD/PPC, with a tweak to nbsdppc-nat. that
> further extends the above with:
>
> nbsdppc-nat is-a inf-ptrace
>
> there were no regressions.
>
> The intent is for all natives to eventually migrate to this.
>
> Comments?
My comments are:
(1) Let's have this machinery documented in gdbint.texinfo.
(2) The patch introduces a couple of user commands (like `udot')
that should be documented in gdb.texinfo.
(3) Several hunks in the patch do not belong to it: they are merely
whitespace adjustments.