This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/testsuite] revert return-type of gdb_file_cmd, gdb_load


I hope this is the end of the mess, but if it's not, just let me know!

Thanks! (Joel, my mips patches will no longer be flying blind ;-)


This patch reverts the recent change to the return value of gdb_file_cmd.
Instead of using a structured return value, I just stick the secondary
information into a global variable.

What of two interfaces -> an existing one with preserved behavior and a new one with extended behavior?


Global variable.  Bleagh.  But "bleagh" beats "oh shit, I broke eight
other implementations of gdb_load in config/*.exp and I can't test all
of them".

Tested on native i686-pc-linux-gnu, gcc 2.95.3 3.3.4 3.4.1,
dwarf-2 and stabs+, with tcl 8.4.6, expect 5.41, dejagnu 1.4.4.

I also tested gdb.gdb/*.exp with a stripped gdb to check for
the proper "untested" results.

I am committing this now.

Andrew




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]