This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA]: Turn on initial Ada support in GDB
- From: Andrew Cagney <cagney at gnu dot org>
- To: Paul Hilfinger <hilfingr at gnat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Tue, 28 Sep 2004 13:58:58 -0400
- Subject: Re: [RFA]: Turn on initial Ada support in GDB
- References: <20040927103327.450A8F2C33@nile.gnat.com>
With the following patch, I believe we have addressed all outstanding
requests for modifications. The most recent changes incorporated here
(to ada-lang.c and ada-lang.h) strip out the code that was #ifdefed
out depending on whether we were compiling from our internal sources
or the public tree, and also remove a few other definitions or
declarations that were unused as a result. The other files in the
patch are repostings of the previously approved portions (not yet applied
because the whole lot is interdependent).
Paul Hilfinger
2004-09-27 Paul N. Hilfinger <Hilfinger@gnat.com>
Turn on initial Ada support (mainly expression evaluation).
* Makefile.in (ada_lex_c): Define
(HFILES_NO_SRCDIR): Add ada-lang.h.
Can these two lines be put on hold for a moment, there's a symtab change
that should be run past the symtab reviewer.
(COMMON_OBS): Add ada-lang.o, ada-typeprint.o, ada-valprint.o.
(YYOBJ): Add ada-exp.o.
otherwize all the Makefile stuff can go in.
(rule .l.c): Generalize to not mention ada.
(ada-lex.o): Remove (ada-lex.c is included by ada-exp.y).
... dig dig, ah, bleaugh :-) Leave this for the moment -> I'll tweak
gdb_makefile.sh to better handle this. Just wonder if the above should
be changed from .l.c to .l.h. (but which ever)?
(ada-lang.o): Add dependencies on completer.h, gdb_obstack.h,
hashtab.h.
(ada-tasks.o): Add dependency on gdb_string.h.
(ada-valprint.o): Add dependency on gdb_string.h.
(ada-exp.o): Add dependency on gdb_string.h.
* symtab.c: Add dependency on ada-lang.h.
(symbol_natural_name): Add Ada case.
(symbol_demangled_name): Add Ada case.
(symbol_search_name): Add Ada case.
This is for symtab review, can you post it separatly?
* symfile.c (init_filename_language_table): Add extensions for
Ada.
Relativly obvious, yes, ok.
* defs.h (enum language): Add language_ada.
M'kay.
* gdbtypes.h (TYPE_FLAG_FIXED_INSTANCE): Define.
It isn't used.
* ada-lang.c: Strip code that is conditionalized out by GNAT_GDB.
(add_symbols_from_enclosing_procs): Make a no-op for now.
(ada_unqualified_name,add_angle_brackets,function_name_from_pc)
(extended_canonical_line_spec, find_sal_from_funcs_and_line)
(find_line_in_linetable, find_next_line_in_linetable)
(read_all_symtabs, is_plausible_func_for_line)
(adjust_pc_past_prologue, error_breakpoint_runtime_sym_not_found)
(is_runtime_sym_defined, check_size): Remove declaration.
(function_name_from_pc, ada_translate_error_message)
(ada_lookup_minimal_symbol): Remove definition.
(ada_add_block_symbols): Remove useless label.
* ada-lang.h (ada_maybe_exception_partial_symbol): Remove
useless declaration.
(ada_is_exception_sym): Likewise.
Yes, and thanks.
doc ChangeLog:
2004-09-22 Paul N. Hilfinger <hilfinger@gnat.com>
* gdb.texinfo (Filenames): Add Ada suffixes.
(Ada) New section.
For Eli, suggest posting it separatly.
Andrew