This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [COMMIT] Accept "\r\n" line-endings on all hosts


Hi Mark,

A good idea, but a few corrections please.  

  # Please email any bugs, comments, and/or additions to this file to:
  # bug-gdb@gnu.org

    Drop this part.

  set file [open "crlf.gdb" "w"]
  puts -nonewline $file "info break\r\n"
  close $file

    Usually I would prefer to have crlf.gdb be a static file.
    In view of the critical nature of the "\r\n" part, I agree with
    Andrew's analysis, doing this in TCL is safer than relying on
    cvs to preserve the line endings.

    But it needs error checking on the statements with external
    effect, especially "open".

  remote_file build delete "crlf.gdb"
  remote_file host delete $cmdfile

    Drop these.  It's good to leave small files lying around after a
    test -- makes it easier to debug if anything goes wrong.

	* gdb.base/crlf.exp: New file.

Michael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]