This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/mips] small code reordering...


[with the patch, this time... Thanks Andrew]

Hello,

The attached patch does a bit of code reordering. The idea was to
get rid of the following FIXME introduced in the previous change
(to avoid bloating the patch with code-moving changes):

    /* FIXME: brobecker/2004-10-15: I suspect these two declarations can
       be removed by a better ordering of the functions below.  But I want
       to do that as a separate change later in order to separate real
       changes and changes that just move some code around.  */

It turns out that I find the new location to be more natural anyway,
so I think the move was more than worthwhile.

Sorry for the obfuscated diff. It's just all cut, move, paste actions.

2004-10-15  Joel Brobecker  <brobecker@gnat.com>

        * mips-tdep.c (mips32_scan_prologue): Move the implementation up
        a bit to avoid the necessity of an advance declaration. Remove
        declaration.
        (set_reg_offset): Move implemenation up.
        (mips16_get_imm): Likewise.
        (mips16_scan_prologue): Likewise.
        (reset_saved_regs): Likewise.
        (mips32_scan_prologue): Likewise.

Comitted.

-- 
Joel

Attachment: move.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]