Re: [obish] Move s/w single-step to mips-linux-tdep.c

[Andrew Cagney <cagney at gnu dot org>]

Andrew Cagney wrote:
> No reason for having the macro, committed.
> Andrew
with [reconstructed] patch.
2004-10-26  Andrew Cagney  <cagney@gnu.org>

	* mips-tdep.h (mips_software_single_step): Move to here ...
	* config/mips/tm-mips.h: ... from here.
	* config/mips/tm-linux.h (SOFTWARE_SINGLE_STEP_P) 
	(SOFTWARE_SINGLE_STEP): Delete.
	* mips-linux-tdep.c (mips_linux_init_abi): Set software_single_step.

Index: mips-linux-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-linux-tdep.c,v
retrieving revision 1.28
retrieving revision 1.29
diff -p -u -r1.28 -r1.29
--- mips-linux-tdep.c	3 Aug 2004 00:57:26 -0000	1.28
+++ mips-linux-tdep.c	26 Oct 2004 14:13:23 -0000	1.29
@@ -1167,6 +1167,8 @@ mips_linux_init_abi (struct gdbarch_info
 
   set_gdbarch_skip_solib_resolver (gdbarch, mips_linux_skip_resolver);
 
+  set_gdbarch_software_single_step (gdbarch, mips_software_single_step);
+
   /* This overrides the MIPS16 stub support from mips-tdep.  But no
      one uses MIPS16 on GNU/Linux yet, so this isn't much of a loss.  */
   set_gdbarch_in_solib_call_trampoline (gdbarch, mips_linux_in_dynsym_stub);
Index: mips-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.h,v
retrieving revision 1.8
retrieving revision 1.9
diff -p -u -r1.8 -r1.9
--- mips-tdep.h	22 Jun 2004 00:01:04 -0000	1.8
+++ mips-tdep.h	26 Oct 2004 14:13:23 -0000	1.9
@@ -74,5 +74,7 @@ enum {
 /* Defined in mips-tdep.c and used in remote-mips.c */
 extern void deprecated_mips_set_processor_regs_hack (void);
 
+/* Single step based on where the current instruction will take us.  */
+extern void mips_software_single_step (enum target_signal, int);
 
 #endif /* MIPS_TDEP_H */
Index: config/mips/tm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-linux.h,v
retrieving revision 1.10
retrieving revision 1.12
diff -p -u -r1.10 -r1.12
--- config/mips/tm-linux.h	30 Apr 2004 20:52:17 -0000	1.10
+++ config/mips/tm-linux.h	26 Oct 2004 14:24:38 -0000	1.12
@@ -39,11 +38,6 @@
 
 #include "config/tm-linux.h"
 
-/* We do single stepping in software.  */
-
-#define SOFTWARE_SINGLE_STEP_P() 1
-#define SOFTWARE_SINGLE_STEP(sig,bp_p) mips_software_single_step (sig, bp_p)
-
 #undef IN_SOLIB_DYNSYM_RESOLVE_CODE
 #define IN_SOLIB_DYNSYM_RESOLVE_CODE(PC) mips_linux_in_dynsym_resolve_code (PC)
 int mips_linux_in_dynsym_resolve_code (CORE_ADDR pc);
Index: config/mips/tm-mips.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-mips.h,v
retrieving revision 1.62
retrieving revision 1.63
diff -p -u -r1.62 -r1.63
--- config/mips/tm-mips.h	2 Sep 2004 14:17:41 -0000	1.62
+++ config/mips/tm-mips.h	26 Oct 2004 14:13:24 -0000	1.63
@@ -107,6 +107,3 @@ extern int mips_ignore_helper (CORE_ADDR
 typedef unsigned long t_inst;	/* Integer big enough to hold an instruction */
 
 #endif /* TM_MIPS_H */
-
-/* Single step based on where the current instruction will take us.  */
-extern void mips_software_single_step (enum target_signal, int);